Skip to content

Conversation

tildechris
Copy link
Contributor

Update header styling, add github link and refine about text.

image

@tildechris tildechris requested a review from kateharwood March 11, 2021 16:47
@kateharwood
Copy link
Contributor

I'm seeing this
Screen Shot 2021-03-12 at 12 55 29 PM

@tildechris
Copy link
Contributor Author

That size issue is odd. Can you try again with this style update? Which browser are you using?

@kateharwood
Copy link
Contributor

kateharwood commented Mar 15, 2021

It's within rstudio, but it looks fine on my browser! Mind if I change the columns to 8 and 1 rather than 7 and 2, so the github element is aligned on the right side of the page like this?
Screen Shot 2021-03-15 at 12 05 14 PM

@tildechris
Copy link
Contributor Author

Ah, that makes sense. I wonder which rendering engine that RStudio uses that demonstrates this behavior but it's not present in Firefox or Chrome.

The columns define the width but not the justification. We could do something like this:

display: flex;
justify-content: flex-end;

Which looks like this:
image

@kateharwood
Copy link
Contributor

Yeah either way, that LGTM!

@tildechris
Copy link
Contributor Author

Updated to right align. I also tested this in RStudio and it renders like I would expect. Can you review?

@kateharwood
Copy link
Contributor

LGTM, in rstudio too!

@tildechris tildechris merged commit 741a8f8 into dev Mar 16, 2021
@tildechris tildechris deleted the about-revision branch March 16, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants