Dashboard dev #48
Merged
Dashboard dev #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review |
tildechris
approved these changes
Mar 16, 2021
dashboard/app.R
Outdated
| @@ -111,32 +112,26 @@ ui <- fluidPage(padding=0, | |||
| "Coverage" = "coverage")), | |||
| selectInput( | |||
| "forecasters", | |||
| "Forecasters (Type a name or select from dropdown)", | |||
| p("Forecasters", tags$br(), tags$span("Type a name or select from dropdown", style="font-weight:normal; font-size:13px")), | |||
There was a problem hiding this comment.
Nit: going forward move styles into style.css
|
|
||
| if (scoreType == "wis") { | ||
| filteredScoreDf <- filteredScoreDf %>% rename(Score = wis) | ||
| title = "Weighted Interval Score" | ||
| # Only show WIS for forecasts that have all intervals | ||
| filteredScoreDf = filteredScoreDf %>% filter(!is.na(`50`)) %>% filter(!is.na(`80`)) %>% filter(!is.na(`95`)) |
There was a problem hiding this comment.
Nit: I think there may be a way to filter by a vector so you only have to write one filter clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.