Skip to content

Conversation

tildechris
Copy link
Contributor

@tildechris tildechris commented Mar 8, 2021

Convert to use markdown instead of big HTML chunks in app.R.

In addition, always show the score description and incident chart; move the footnote text to the bottom of the screen.

@tildechris tildechris requested a review from kateharwood March 8, 2021 22:25
@tildechris
Copy link
Contributor Author

image

@kateharwood let's chat about the layout tomorrow. I see where you were indenting the content but the content areas were already aligned.

It seems you wanted the text to align with where the y-axis on the plots start, which we can do, but that's semantically a bit different.

This shows the explanation indented one "column" and the "Some forecasters" aligned with where the figures start.

@kateharwood
Copy link
Contributor

kateharwood commented Mar 9, 2021

I agree the 1 col looks fine (but I do think all the text should be aligned at the same indentation). This PR changes the functionality of the score explanations, did you intend that?
Before (score explanation is in dropdown, not automatically shown):
Screen Shot 2021-03-09 at 11 12 15 AM

After:
Screen Shot 2021-03-09 at 11 11 33 AM

There is so much text that is under the main plot (and I am about to add more per Nick's request) explaining methods / giving disclaimers that I'm not sure we want more showing by default. Or at least we should have it separated or with a "Explanation of Score" header if not the dropdown.

The score explanation also flashes at the top before the app finishes loading the plots.

@tildechris tildechris changed the title Use markdown Use markdown and update chart visibility and order Mar 10, 2021
@tildechris
Copy link
Contributor Author

image

image

@tildechris
Copy link
Contributor Author

@kateharwood this is ready for review now.

@kateharwood
Copy link
Contributor

kateharwood commented Mar 10, 2021

I still think it's really odd that the description shows up at the top before the plots load. It's more than a negligible amount of time. I wonder if there is a way around that. I also feel like the score explanation text should stretch the width of the plots rather that cutting off part way.

@kateharwood kateharwood merged commit c09ff5d into dev Mar 10, 2021
@kateharwood kateharwood deleted the use-markdown branch March 30, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants