Skip to content

Conversation

nmdefries
Copy link
Collaborator

@nmdefries nmdefries commented Jun 30, 2023

Besides the Node16 warnings, our workflows also have "The set-output command is deprecated and will be disabled soon" and "The save-state command is deprecated and will be disabled soon" errors, even in workflows that don't use those commands. I updated various actions we use to their newest versions incorporating the new Node version and environment files.

On workflows that use the set-output command, I replaced with the GITHUB_OUTPUT file, as recommended.

@nmdefries nmdefries requested a review from dmytrotsko July 3, 2023 21:17
Copy link

@dmytrotsko dmytrotsko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm the right person to review, but it looks LGTMT for me.

@nmdefries
Copy link
Collaborator Author

@dmytrotsko I heard you've worked on workflows most recently, so I thought you'd be the best reviewer! The content of the repo isn't relevant to the changes here 👍

Copy link
Collaborator

@dsweber2 dsweber2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to y'all's judgement on this

@nmdefries nmdefries merged commit 7ed8881 into dev Jul 11, 2023
@nmdefries nmdefries deleted the ndefries/workflow-warnings branch July 11, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants