Skip to content

Conversation

nmdefries
Copy link
Collaborator

Allow as-of dates to go farther back in time now that JHU as-of history has been backfilled.

Closes #187.

@nmdefries nmdefries requested a review from krivard December 2, 2021 22:33
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked these in the DB and they look good modulo futureproofing

MIN_AVAIL_HOSP_AS_OF_DATE <- as.Date("2020-11-11")
MIN_AVAIL_TERRITORY_AS_OF_DATE <- as.Date("2021-02-10")
MIN_AVAIL_NATION_AS_OF_DATE <- as.Date("2020-04-02")
MIN_AVAIL_HOSP_AS_OF_DATE <- as.Date("2020-11-16")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this matters yet but flu signals from hhs are only available back to as_of 2021-09-20

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 will keep an eye on that.

@nmdefries nmdefries merged commit 6932c69 into dev Dec 13, 2021
@nmdefries nmdefries deleted the extend-asof-date-selection branch December 13, 2021 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As Of only goes back to February
2 participants