Skip to content

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Mar 27, 2025

Checklist

Please:

  • Make sure this PR is against "dev", not "main" (unless this is a release
    PR).
  • Request a review from one of the current main reviewers:
    brookslogan, nmdefries.
  • Makes sure to bump the version number in DESCRIPTION. Always increment
    the patch version number (the third number), unless you are making a
    release PR from dev to main, in which case increment the minor version
    number (the second number).
  • Describe changes made in NEWS.md, making sure breaking changes
    (backwards-incompatible changes to the documented interface) are noted.
    Collect the changes under the next release number (e.g. if you are on
    1.7.2, then write your changes under the 1.8 heading).
  • See DEVELOPMENT.md for more information on the development
    process.

Change explanations for reviewer

Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch

  • Resolves #{issue number}

@dshemetov dshemetov requested review from dsweber2 and brookslogan and removed request for dsweber2 March 27, 2025 01:08
@brookslogan
Copy link
Contributor

brookslogan commented Mar 29, 2025

Previously, we had is_epi_archive with a something like a grouped_okay arg deciding whether to count grouped archives or not. Does that sound useful?

Pre-merge-wise I just need to sanity-check the docs output. Can't tell what to expect from skimming the diff alone.

Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spiffed up the docs a bit and put an (old) idea into #649. Think this is good to merge although I might wait a tiny bit if you feel like double-checking the docs change.

@dshemetov
Copy link
Contributor Author

/preview-docs

Copy link

@dshemetov dshemetov merged commit 91f6654 into dev Mar 31, 2025
3 checks passed
@dshemetov dshemetov deleted the ds/is_archive branch March 31, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants