Update package-lock file to point to cmu-delphi URL for delphi-cmu-buildtools

[krivard]

Currently uses the URL in sgratzl's org:

delphi-epidata/package-lock.json

Line 9 in 92e0027

"delphi-cmu-buildtools": "git+https://github.com/sgratzl/delphi-cmu-buildtools.git"

the repo itself was already moved to this org, so that URL redirects here, but seeing it in package-lock gave us a bit of a start.

[melange396]

Getting rid of the ssh in that uri scheme was key, and resolving to our org in the delphi-cmu-buildtools repo reference instead of relying on the forwarding from Sam's org is more than appropriate futureproofing, but some questions that remain about this file and its changes... Was the previous change to package-lock.json intentional and/or desirable? Typically package-lock.json is generated from package.json by npm but no changes were made to package.json, so what was the reason or purpose? The reference to delphi-cmu-buildtools contains a pinned version/commit-id "#c8d0e495f7b2f6aed842976860c7b00b0d65af70" which is actually 2 commits behind the HEAD for that repo -- it wasnt updated with the change to package-lock.json, but should it have been? And how did the apparently non-working ssh uri get introduced in the first place???

[dshemetov]

Since package-lock.json is generated by npm, it likely depends on the details of the developer's build system. Is there a chance @LeonLu2 used a local npm to build the documentation which put his local git settings into package-lock.json (instead of doing it in Docker, which I assume has an unconfigured git if it has one at all)? Just a guess.

[melange396]

i think your guess is spot on. i also think we might wanna revert the changes to the package-lock file (other than the org swap for delphi-cmu-buildtools) unless @LeonLu2 thinks its better this way. do we also want to pull in the newer changes from delphi-cmu-buildtools?

[LeonLu2]

Sorry, I think the change to the package-lock was unintentional. I can revert that :)