Skip to content

Refactor Usafacts to use smoothing utils #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 12, 2020
Merged

Refactor Usafacts to use smoothing utils #429

merged 6 commits into from
Nov 12, 2020

Conversation

chinandrew
Copy link
Contributor

Closes #428

Summary of Changes:

  • Update USAFacts to use the utils smoother utility
  • Delete old smooth file and test

@chinandrew chinandrew changed the title Usafacts smooth refactor Refactor Usafacts to use smoothing utils Nov 4, 2020
@chinandrew
Copy link
Contributor Author

blocked by #437

@krivard krivard added the blocked This task is waiting for completion of another task label Nov 5, 2020
@chinandrew chinandrew mentioned this pull request Nov 9, 2020
Closed
7 tasks
@chinandrew
Copy link
Contributor Author

unblocked

@chinandrew chinandrew removed the blocked This task is waiting for completion of another task label Nov 10, 2020
@chinandrew
Copy link
Contributor Author

blocked by new bug with indices on smoothing

@chinandrew chinandrew added the blocked This task is waiting for completion of another task label Nov 10, 2020
@chinandrew chinandrew marked this pull request as draft November 10, 2020 16:42
@chinandrew chinandrew marked this pull request as ready for review November 10, 2020 16:42
@krivard krivard removed the blocked This task is waiting for completion of another task label Nov 11, 2020
@krivard
Copy link
Contributor

krivard commented Nov 11, 2020

@chinandrew sorry I unblocked without seeing the full thread. Was the smoothing indices bug fixed by #478 ?

@chinandrew
Copy link
Contributor Author

@chinandrew sorry I unblocked without seeing the full thread. Was the smoothing indices bug fixed by #478 ?

Yup

@krivard krivard merged commit f80926f into main Nov 12, 2020
@krivard krivard deleted the usafacts-smooth-refactor branch November 12, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

usafacts - smoothing refactor
2 participants
@chinandrew @krivard