Nwss: state+nation level #1913
Merged
Nwss: state+nation level #1913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmdefries
requested review from
a team and
nolangormley
and removed request for
a team
nolangormley
requested changes
Dec 14, 2023
Contributor
nolangormley
left a comment
nolangormley
left a comment
There was a problem hiding this comment.
Mostly looks good.
Missing a receiving folder, tests, and some small nitpicks.
remove daily_receiving
Prepare nwss for staging
melange396
reviewed
Jan 9, 2024
Contributor
melange396
left a comment
melange396
left a comment
There was a problem hiding this comment.
sorry for the late review. any indication on how long this takes to run (average/typical)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding state and national aggregations of the NWSS wastewater data. Aggregation from the sample site to state/nation is weighted by population (with NA population values not included for the total for their respective states; we don't have an exhaustive sample anyway), with the population estimates taken from the corresponding "metric" dataset on a day by day basis. I couldn't use the geo-mapper because the
population_serveddepends on the day, sometimes by an order of magnitude.For previous discussion, see this issue. That will be ongoing after this, as there's still sample-site level and county-level aggregations to include. Those are more involved.
make lintdoesn't seem to be working on my machine, even if the actual commands run on their own do. Not sure why we're pinning the python version to 3.8 to run that. It's at 8.9/10 when run viapylint delphi_NWSSdirectly, and the problems are things likeunable to import delphi_tools.Currently still needs tests;
env/bin/python -m delpi_NWSSworks, with the output confirmed to be of the right general form.@rlunde I'm not sure who exactly is the right person to be tagging this for review