Skip to content

Conversation

@patrickhyw
Copy link
Member

@patrickhyw patrickhyw commented Dec 30, 2024

Summary: The codebase is now fully refactored to use the new open_and_save(), save_file(), and link_result() functions from #66. The old functions have been removed.

Demo:
Wrote two new integration test files that pass.
Screenshot 2024-12-30 at 10 45 53
Screenshot 2024-12-30 at 10 50 10

Details

  • Refactored dbms/ and benchmark/ to use the new files. Wrote tests for both too.
  • Moved path functions from workspace.py to gymlib/symlinks_paths.py.
    • This is important because agents will need access to the DBMS/benchmark paths.
  • Renamed all occurrences of dpath/fpath/fordpath to path. Renamed dname/fname to dirname/filename.
    • Names could refer to conceptual names so we add dir/file to the front to disambiguate.
    • Paths are not ambiguous though so we just call them paths. Whether they're a directory or file matters a little, but I think it's cleaner to just call them paths since that's the general standard.

@patrickhyw patrickhyw changed the title Integtest dbms benchmark draft pr for ci Dec 30, 2024
@patrickhyw patrickhyw force-pushed the integtest-dbms-benchmark branch from 2c44f47 to 85f40a0 Compare December 30, 2024 02:03
@patrickhyw patrickhyw changed the title draft pr for ci Fully using new workspace Dec 30, 2024
@patrickhyw patrickhyw merged commit 34a47c0 into cmu-db:main Dec 30, 2024
1 check passed
@patrickhyw patrickhyw deleted the integtest-dbms-benchmark branch December 30, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant