Skip to content

Conversation

@SweetOps
Copy link
Contributor

what

  • add possibility to disable resources creation

why

  • useful for multi-workspaces terraform projects

@SweetOps
Copy link
Contributor Author

@osterman would be nice to get code review

@Gowiem
Copy link
Member

Gowiem commented Jun 18, 2020

/rebuild-readme

@SweetOps SweetOps requested a review from a team as a code owner June 18, 2020 15:28
@SweetOps SweetOps requested review from adamcrews and nitrocode and removed request for a team June 18, 2020 15:28
@Gowiem
Copy link
Member

Gowiem commented Jun 18, 2020

@SweetOps Can you resolve these conflicts? Thanks man.

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested merge conflict fix.

@SweetOps
Copy link
Contributor Author

@Gowiem fixed

btw, I've several open PR's in others repos which are stuck... would be to merge them also
cloudposse/terraform-aws-route53-cluster-zone#27
cloudposse/terraform-aws-ec2-instance-group#10
cloudposse/terraform-aws-dynamic-subnets#87

@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

/test all

@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

/terraform-fmt

@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

/test all

@Gowiem Gowiem merged commit b2df4eb into cloudposse:master Jun 19, 2020
@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

@SweetOps Thanks for the contribution! Released as 0.14.0.

@Gowiem
Copy link
Member

Gowiem commented Jun 19, 2020

@SweetOps Regarding your other PRs, we'll get to em as fast as we can 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants