Skip to content

Conversation

@nitrocode
Copy link
Member

what

  • remove lifecycle ignore changes for ami argument

why

  • This change looks unintentional based on the PR description
  • We'd like to allow AMIs to recreate the EC2 for singletons that aren't production facing

references

This change looks unintentional based on the PR description
@nitrocode nitrocode requested review from a team as code owners August 17, 2024 22:04
@nitrocode nitrocode requested review from Gowiem and joe-niland August 17, 2024 22:04
@mergify mergify bot added the triage Needs triage label Aug 17, 2024
@mergify mergify bot removed the triage Needs triage label Aug 17, 2024
@nitrocode
Copy link
Member Author

/terratest

@nitrocode nitrocode enabled auto-merge (squash) August 17, 2024 22:52
@nitrocode nitrocode merged commit c4be480 into main Aug 17, 2024
@nitrocode nitrocode deleted the rm-ami-ignore-changes branch August 17, 2024 23:01
@github-actions
Copy link
Contributor

These changes were released in v1.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants