Feature/update label

[Jamie-BitFlight]

what

Updated the label module to 0.11.1, allowed the use of context for a DRY'er finish

why

Allows for fewer repeated variables. Allows users of the label module to pass context into this module.

[osterman]

I'm okay with splitting out the label into a separate file, but maybe combine them into one file?

[aknysh]

see comments

[Jamie-BitFlight]

Updated to comply

[aknysh]

thanks @Jamie-BitFlight
please see comments

[aknysh]

Suggested change

	description = "[Label Module] The naming order of the id output and Name tag"
	description = "The naming order of the id output and Name tag"

I think we don't need to use [Label Module] in the descriptions, it makes it more difficult to read

[Jamie-BitFlight]

I understand. I was wanting a way to categorise the label modules inputs, so that they could be separated from the dynamic subnets module variables.
Is there another way we could categorise it in the readme @aknysh?

[aknysh]

@Jamie-BitFlight
The README generator reads all descriptions and puts them into README (so no fast way to categorize them).
I think we don't need to categorize with [Label Module], the users of the module (and other CloudPosse modules) are already familiar with the label attributes, so there is no reason to separate them from other module's variables

[aknysh]

thanks @Jamie-BitFlight
please see comments

[Jamie-BitFlight]

Ok 👌  Regards Jamie Nelson‬ -/- On Jun 7, 2019, at 3:54 PM, Andriy Knysh <[email protected] <mailto:[email protected]> > wrote: @aknysh commented on this pull request.

-------------------------------- In label.tf:

+ additional_tag_map = "${var.additional_tag_map}"

+ regex_replace_chars = "${var.regex_replace_chars}" + label_order = "${var.label_order}" + context = "${var.context}" +} + +variable "additional_tag_map" { + type = "map" + default = {} + description = "Additional tags for appending to each tag map" +} + +variable "label_order" { + type = "list" + default = [] + description = "[Label Module] The naming order of the id output and Name tag" @Jamie-BitFlight The README generator reads all descriptions and puts them into README (so no fast way to categorize them). I think we don't need to categorize with [Label Module], the users of the module (and other CloudPosse modules) are already familiar with the label attributes, so there is no reason to separate them from other module's variables — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[aknysh]

thanks @Jamie-BitFlight