Skip to content

Include Availability Zone name in resources that are 1 per AZ #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Nuru merged 2 commits into from
Apr 11, 2019
Merged

Include Availability Zone name in resources that are 1 per AZ #46

Nuru merged 2 commits into from
Apr 11, 2019

Conversation

@Nuru
Copy link
Contributor

@Nuru Nuru commented Apr 11, 2019

what

  • Include Availability Zone name in resources that are 1 per Availability Zone
  • Ignore AWS tags created by kops and kubernetes

why

  • Make it easy to determine which resources are in which availability zone
  • Prevent Terraform from removing tags that kops and kubernetes use to manage resources

@Nuru Nuru requested review from aknysh, goruha and osterman April 11, 2019 04:41
@Nuru Nuru merged commit 973c845 into master Apr 11, 2019
@Nuru Nuru deleted the common-vpc branch April 11, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknysh aknysh aknysh approved these changes

@goruha goruha Awaiting requested review from goruha

@osterman osterman Awaiting requested review from osterman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nuru @aknysh