Skip to content

Conversation

@davenicoll
Copy link
Contributor

what

  • Changed tfsec ignore comments to use the rule name, rather than deprecated IDs
  • Added ignores to public and private so that tfsec passes the module without CRITICAL issues

why

  • tfsec no longer supports #tfsec:ignore:AWS012 style comments
  • False positives generated by this module have been ignored

@davenicoll davenicoll requested review from a team as code owners May 16, 2023 21:26
@jamengual
Copy link
Contributor

/test all

@davenicoll davenicoll requested a review from a team as a code owner May 17, 2023 15:29
@jamengual
Copy link
Contributor

@max-lobur is there anything @davenicoll or me needs to do to fix this? reviewdog: This GitHub token doesn't have write permission of Review API [1], so reviewdog will report results via logging command [2] and create annotations similar to

@max-lobur
Copy link
Contributor

@max-lobur is there anything @davenicoll or me needs to do to fix this? reviewdog: This GitHub token doesn't have write permission of Review API [1], so reviewdog will report results via logging command [2] and create annotations similar to

This is expected for forks.
But the original tflint complaint looks weird though

Screen Shot 2023-05-18 at 3 13 20 PM

@max-lobur
Copy link
Contributor

This should fix it #180

@max-lobur
Copy link
Contributor

/terratest

@max-lobur max-lobur merged commit ec00f45 into cloudposse:main May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants