- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 170
PROPOSAL: Single NGW option #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /test all | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nnsense thank you for the PR
Please see comments.
can you please run the following command
make init
make github/init
make readme
and commit the changes
| Why even bother running in multiple AZs if you only deploy a single NGW? If you lose the AZ with the NGW, all other AZs lose egress. If the concern is cost, then reduce the number of AZs, not the number of NGWs. It's a false sense of redundancy. What's the counter argument? | 
| 
 In accounts like audit, security, etc you might do more management than deploying services and on those, you might not even have critical services in them but you might need to have a way to connect to the internet but not highly available (like for sending reports, analytics etc) In an account that you use for back end services connected through a TGW and you have multiple RDS clusters that are highly available but the egress is through the TGW and not the NGW you might not need that many NGWs in companies with low budgets. | 
This Pull Request has been updated, so we're dismissing all reviews.
| Hi @osterman , that is of course a good point, but in our case we didn't want to change the infrastructure, just pay for a single NGW while developing with a single server which we had the chance to run in HA for testing (still using a single NGW) and the reduce back to single. At the time we needed to save money, and I've been using this branch to deploy a single NGW | 
| /test all | 
| @nnsense can you address the comment? | 
| Hi @jamengual - Sorry I'm a bit lost, what comment I need to address? | 
| Andry comment about the name of the locals… On Sat., Apr. 16, 2022, 2:53 a.m. nnsense, ***@***.***> wrote:
 Hi @jamengual <https://github.com/jamengual> - Sorry I'm a bit lost, what
 comment I need to address?
 —
 Reply to this email directly, view it on GitHub
 <#154 (comment)>,
 or unsubscribe
 <https://github.com/notifications/unsubscribe-auth/AAQ3ERHJUNUZHIM6ZNQVTTTVFKEZ7ANCNFSM5TNK7TZA>
 .
 You are receiving this because you were mentioned.Message ID:
 ***@***.***>
 | 
| Done, thanks I've missed that comment :) | 
| /test all | 
| 
 In that case, why run more than one subnet if running a single server? | 
| 
 Yep, I don't disagree wit the use-case. But then why have multiple AZs instead of single AZ? A single AZ communicates that it's not HA. | 
| 
 Erik, if this was an account that has only Aurora RDS clusters and the internet is not the primary ingress then you might not want to run multiple nat gateways, I know this is not what ClousPosse recommends but it is a very common practice and that is why this option is disabled by default. | 
| 
 Okay, I can accept that. | 
| default = true | ||
| } | ||
|  | ||
| variable "single_nat_gateway" { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, we should change this to max_nat_gateways. There's some code stink about calling it single, when single isn't the primary concern. It's the number of nat gateways to reduce cost. Operating in 5 AZs, it might be desirable to have 2 NAT gateways instead.
| @nnsense please look at the new comments | 
This Pull Request has been updated, so we're dismissing all reviews.
| @nnsense can you address the rename change from Erik ( I know we asked for this before, sorry) so we can get this merged? thanks. | 
| Hi @jamengual @osterman | 
| @Nuru @jamengual | 
| @Nuru @jamengual @osterman | 
what
why