FIX pypy3 support for method descriptors #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@mrocklin this test was introduced in your last PR. Can you please give a quick look at this complementary fix? |
Contributor
|
This looks innocuous to me. |
Member
|
Travis passed while codecov did not. Not sure how to interpret the codecov page. Is it a failure because coverage decreased? |
Contributor
Author
Yes. I think the threshold is too sensitive. Alternatively we might want to investigate if there is a way to consolidate the coverage of the tests run on all the python versions run by travis on a single branch. Maybe later, let's merge this ;) |
ogrisel
added a commit
that referenced
this pull request
Jan 20, 2016
FIX pypy3 support for method descriptors
Member
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #50.