Skip to content

Conversation

@pierreglaser
Copy link
Member

test_builtin_function used to pickle sys.getcheckinterval, which was removed in python 3.9 following: https://bugs.python.org/issue37392, making the python-nighly build of cloudpickle's CI fail. This PR changes the usage of getcheckinterval to os.mkdir (arbitrary)

@llllllllll
Copy link
Contributor

LGTM, hopefully os.mkdir isn't going away any time soon.

@codecov
Copy link

codecov bot commented Jul 17, 2019

Codecov Report

Merging #300 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   92.84%   92.84%           
=======================================
  Files           2        2           
  Lines         852      852           
  Branches      177      177           
=======================================
  Hits          791      791           
  Misses         37       37           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2db58f1...205b21b. Read the comment docs.

@pierreglaser pierreglaser merged commit 5c0a0b1 into cloudpipe:master Jul 23, 2019
@pierreglaser pierreglaser deleted the stop-using-getcheckinterval branch July 23, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants