Replace lager usage with log/slog in mysql-metrics #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
slog is faster and simpler and reduces the amount of data logged while improving the clarity of the logs. This removes an external third party dependency chain and simply uses the Go stdlib log/slog for logging. The old log format was maintained as much as possible by using slog.ReplaceAttr and maintaing the legacy nested "data.metric" structure of the existing package. However the "source" key has been removed - this always had a static "MetricsEmitter" value that seemed low value and whose removal would not be missed.
abg
force-pushed
the
chore/replace-lager-with-slog
branch
from
aa7ebd2 to
339d1cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
slog is faster and simpler and reduces the amount of data logged while improving the clarity of the logs.
This removes an external third party dependency chain and simply uses the Go stdlib log/slog for logging.
The old log format was maintained as much as possible by using slog.ReplaceAttr and maintaing the legacy nested "data.metric" structure of the existing package. However the "source" key has been removed - this always had a static "MetricsEmitter" value that seemed low value and whose removal would not be missed.