Flaky hunt #3455
Open
Flaky hunt #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
joergdw
commented
Jan 21, 2025
Comment on lines
+136
to
+137
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); // ⏳ Waiting time to ensure, the db had … | ||
| // … enough time to delete the job. |
There was a problem hiding this comment.
Actually I wanted to write rather
Suggested change
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); // ⏳ Waiting time to ensure, the db had … | |
| // … enough time to delete the job. | |
| // ⏳ Waiting time to ensure, the db had enough time to delete the job. | |
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); | |
or at least
Suggested change
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); // ⏳ Waiting time to ensure, the db had … | |
| // … enough time to delete the job. | |
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); // ⏳ Waiting time to ensure, the db had … | |
| // … enough time to delete the job. |
But that java-style-guide does not like it.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
devbox.lock
Outdated
| "plugin_version": "0.0.4", | ||
| "resolved": "github:NixOS/nixpkgs/5629520edecb69630a3f4d17d3d33fc96c13f6fe#python3", | ||
| "last_modified": "2024-12-23T21:10:33Z", | ||
| "plugin_version": "0.0.3", |
There was a problem hiding this comment.
[markdownlint-fix] reported by reviewdog 🐶
Suggested change
| "plugin_version": "0.0.3", | |
| "plugin_version": "0.0.4", |
joergdw
commented
Jan 21, 2025
| @@ -133,6 +133,8 @@ public void testDeleteSchedule() throws Exception { | |||
| mockMvc.perform( | |||
| delete(TestDataSetupHelper.getSchedulerPath(appId)).accept(MediaType.APPLICATION_JSON)); | |||
|
|
|||
| java.util.concurrent.TimeUnit.SECONDS.sleep(5); // ⏳ Waiting time to ensure, the db had … | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first instance, this PR is to detect flaky tests and provoke their failure.