chore: fix CI code coverage publishing #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code coverage publishing in package.json works fine on non-ubuntu systems. However, in Ubuntu `/bin/sh` is symlinked to `/bin/dash` which doesn't support everything supported by `/bin/bash` - specifically `-o pipefail`. This commit changes the code coverage script to explicitly use `bash` instead. Signed-off-by: Lance Ball <[email protected]>
lance
force-pushed
the
fix-codacy-publish
branch
from
d0802eb to
9896f08
Compare
|
@fabiojose I think this should fix it. Without Travis and Codacy credentials for this repository, I can't test in advance. We shall see :) |
|
Note: coverage results are only published when a commit lands on |
|
FYI - in Codacy, it is possible to have the quality check fail if code coverage is reduced. Might be a good idea to do that. |
grant
approved these changes
Apr 29, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code coverage publishing in package.json works fine on non-ubuntu systems.
However, in Ubuntu
/bin/shis symlinked to/bin/dashwhich doesn't supporteverything supported by
/bin/bash- specifically-o pipefail.This commit changes the code coverage script to explicitly use
bashinstead.Signed-off-by: Lance Ball [email protected]