Travis is Flaky

[grant]

Travis looks like it is flaky. I have added some PRs that don't affect the tests, yet Travis seems to fail.

Example:
#74

Ideally a PR like this shouldn't fail.

[lance]

I think this will be resolved with #78

: It was resolved

[grant]

Hi, can we please keep the issue open until we're sure the issue is fixed? Did we test that this is fixed?
I'm still seeing the issue.

Here is trace from a test I ran after the PR merged:

> cloudevents-sdk@1.0.0 coverage-publish /home/travis/build/cloudevents/sdk-javascript
> wget -qO - https://coverage.codacy.com/get.sh | sh -s report -l JavaScript -r coverage/lcov.info
sh: 3: set: Illegal option -o pipefail
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! cloudevents-sdk@1.0.0 coverage-publish: `wget -qO - https://coverage.codacy.com/get.sh | sh -s report -l JavaScript -r coverage/lcov.info`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the cloudevents-sdk@1.0.0 coverage-publish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2020-04-29T16_16_53_094Z-debug.log
The command "if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then npm run coverage-publish; else npm test; fi" exited with 2.
cache.2
store build cache

[lance]

Not sure where that failure is happening now. Can you link to it? All of the recent CI runs for pull requests are passing: https://travis-ci.org/github/cloudevents/sdk-javascript/pull_requests

And the CI run for #78 passed: https://travis-ci.org/github/cloudevents/sdk-javascript/builds/681089567.

And current master passes: https://travis-ci.org/github/cloudevents/sdk-javascript/builds/681087308

It seems the failure is only happening on your branches. Maybe you haven't pulled that commit in yet?

Also - I'm curious... Why are you creating fix branches on upstream and not on your own fork?

[lance]

Also - I'm curious... Why are you creating fix branches on upstream and not on your own fork?

This also makes me wonder if it really makes sense for the Travis-CI configuration to build all branches. Perhaps it should be configured to build only from master and any release branches. (Speaking of... it would probably make sense to create release branches).

https://travis-ci.org/github/cloudevents/sdk-javascript/branches

[lance]

@grant - looks like you got the CI issues worked out. OK to close this now?

[grant]

Looks like it's been fixed and the signing issue isn't a problem anymore. Fixed on master. Thanks for checking. Closing.