Skip to content

Update CI action to node 18.x #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/nodejs-ci-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
node-version: [12.x, 14.x, 16.x, 18.x]

steps:
- uses: actions/checkout@v2
Expand All @@ -37,7 +37,7 @@ jobs:
- name: Generate coverage report
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- run: npm ci
- run: npm run build --if-present
- run: npm run coverage
Expand All @@ -60,7 +60,7 @@ jobs:
- name: Upload coverage report to codacy
uses: actions/setup-node@v1
with:
node-version: 16.x
node-version: 18.x
- run: |
( [[ "${CODACY_PROJECT_TOKEN}" != "" ]] && npm run coverage-publish ) || echo "Coverage report not published"
env:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ _Note:_ Supports CloudEvent version 1.0
## Installation

The CloudEvents SDK requires a current LTS version of Node.js. At the moment
those are Node.js 12.x, Node.js 14.x and Node.js 16.x. To install in your Node.js project:
those are Node.js 12.x, Node.js 14.x, Node.js 16.x, and Node.js 18.x. To install in your Node.js project:

```console
npm install cloudevents
Expand Down