Skip to content

deps: update old and remove unused dependencies #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
language: node_js
node_js:
- 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People with node 8, 7 and 6 will be able to use cloudevent released with version 12?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's possible, but not guaranteed. I don't think the SDK uses language features that are not available in 6, 7 and 8. But I question the wisdom of even attempting to support a Node.js version that is end of life. Both 6 and 8 are EOL, and 7 was never an LTS version (no odd numbered versions of Node.js should be considered LTS ever).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- 7
- 6
- 12
- 10
cache: npm
jobs:
include:
- stage: github release
node_js: '6'
node_js: '12'
deploy:
provider: releases
api_key:
Expand All @@ -17,7 +16,7 @@ jobs:
tags: true

- stage: npm release
node_js: '6'
node_js: '12'
deploy:
provider: npm
email: [email protected]
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

- Support for mTLS in v1.0 Binary and Structured Emitters: issue [#48](https://github.com/cloudevents/sdk-javascript/issues/48). Note that this fix is only valid for v1.0 and does not address the problem in v0.3 and below.

### Removed

- Removed support for Node.js 6, 7 and 8 - all of which are EOL at this point. Travis CI modified to test on Node.js 10 and 12.

## [1.0.0]

### Added
Expand Down
3 changes: 1 addition & 2 deletions lib/bindings/http/emitter_binary.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const axios = require("axios");
const empty = require("is-empty");
var axios = require("axios");

const Constants = require("./constants.js");
const defaults = {};
Expand Down
5 changes: 2 additions & 3 deletions lib/specs/spec_0_2.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const uuid = require("uuid/v4");
const empty = require("is-empty");
const Ajv = require("ajv");
var uuid = require("uuid/v4");
var Ajv = require("ajv");

// Reserved attributes names
const reserved = {
Expand Down
1 change: 0 additions & 1 deletion lib/specs/spec_0_3.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const uuid = require("uuid/v4");
const empty = require("is-empty");
const Ajv = require("ajv");

const {
Expand Down
2 changes: 0 additions & 2 deletions lib/specs/spec_1.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const uuid = require("uuid/v4");
const empty = require("is-empty");
const Ajv = require("ajv");
const URI = require("uri-js");

const {
asData,
Expand Down
Loading