fix: improve binary data detection in HTTP transport #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were only checking for a single typed array, `UInt32Array` but that's not quite broad enough, since binary data can exist in various forms. This means of checking for binary data, using `types.isTypedArray` is not foolproof, but is better than previous, as the previous implementation would not recognize a PNG file read from disk via `fs.readFileSync` as binary data. Now it will. Signed-off-by: Lance Ball <[email protected]>
grant
approved these changes
Feb 1, 2022
Signed-off-by: Lance Ball <[email protected]>
lance
added a commit
to lance/faas-js-runtime
that referenced
this pull request
Feb 1, 2022
Depends on: cloudevents/sdk-javascript#468 Fixes: nodeshift#64 Signed-off-by: Lance Ball <[email protected]>
lholmquist
approved these changes
Feb 1, 2022
lance
added a commit
to nodeshift/faas-js-runtime
that referenced
this pull request
Feb 9, 2022
Depends on: cloudevents/sdk-javascript#468 Fixes: #64 Signed-off-by: Lance Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were only checking for a single typed array,
UInt32Arraybut that's not quite broad enough, since binary data can exist in various forms. This means of checking for binary data, usingtypes.isTypedArrayis not foolproof, but is better than previous, as the previous implementation would not recognize a PNG file read from disk viafs.readFileSyncas binary data. Now it will.Signed-off-by: Lance Ball [email protected]