fix: do not assume an empty content-type header is JSON #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser for HTTP binary made the assumption that if there was no `content-type` header in the incoming message, it should inject `application/json`. Discussion about the rationale for this is in cloudevents#441. This commit, removes that injection and adds a test to ensure the bytes are simply not parsed, but just passed along untouched. Fixes: cloudevents#441 Signed-off-by: Lance Ball <[email protected]>
|
@grant or @lholmquist would one of you ptal 😺 |
lholmquist
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser for HTTP binary made the assumption that if there was no
content-typeheader in the incoming message, it should inject
application/json. Discussionabout the rationale for this is in #441.
This commit removes that injection and adds a test to ensure the bytes are not parsed, but just passed along untouched.
Fixes: #441
Signed-off-by: Lance Ball [email protected]