Skip to content

lib: Changed Array instantiation and object creation #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 31 additions & 61 deletions lib/bindings/http/receiver_binary_1.js
Original file line number Diff line number Diff line change
@@ -1,82 +1,52 @@
const Constants = require("./constants.js");
const Spec = require("../../specs/spec_1.js");
const {
MIME_JSON,
MIME_OCTET_STREAM,
ENCODING_BASE64,
BINARY_HEADERS_1,
HEADER_CONTENT_TYPE,
SPEC_V1
} = require("./constants.js");

const Spec = require("../../specs/spec_1.js");
const JSONParser = require("../../formats/json/parser.js");
const Base64Parser = require("../../formats/base64.js");

const BinaryHTTPReceiver = require("./receiver_binary.js");

const {
isString,
isBase64
} = require("../../utils/fun.js");

const parserByType = {};
parserByType[Constants.MIME_JSON] = new JSONParser();
parserByType[Constants.MIME_OCTET_STREAM] = {
parse(payload) { return payload; }
const parserByType = {
[MIME_JSON] : new JSONParser(),
[MIME_OCTET_STREAM] : { parse(payload) { return payload; } }
};

const parsersByEncoding = {};
parsersByEncoding.null = parserByType;
parsersByEncoding[undefined] = parserByType;

// base64
parsersByEncoding[Constants.ENCODING_BASE64] = {};
parsersByEncoding[Constants.ENCODING_BASE64][Constants.MIME_JSON] =
new JSONParser(new Base64Parser());
parsersByEncoding[Constants.ENCODING_BASE64][Constants.MIME_OCTET_STREAM] = {
parse(payload) { return payload; }
const parsersByEncoding = { [null] : parserByType, [undefined] : parserByType, [ENCODING_BASE64] : {} };
parsersByEncoding[ENCODING_BASE64][MIME_JSON] = new JSONParser(new Base64Parser());
parsersByEncoding[ENCODING_BASE64][MIME_OCTET_STREAM] = {
parse(payload) { return payload; }
};

const allowedContentTypes = [];
allowedContentTypes.push(Constants.MIME_JSON);
allowedContentTypes.push(Constants.MIME_OCTET_STREAM);
const allowedContentTypes = [MIME_JSON, MIME_OCTET_STREAM];

const requiredHeaders = [];
requiredHeaders.push(Constants.BINARY_HEADERS_1.TYPE);
requiredHeaders.push(Constants.BINARY_HEADERS_1.SPEC_VERSION);
requiredHeaders.push(Constants.BINARY_HEADERS_1.SOURCE);
requiredHeaders.push(Constants.BINARY_HEADERS_1.ID);
const requiredHeaders = [BINARY_HEADERS_1.TYPE, BINARY_HEADERS_1.SPEC_VERSION,
BINARY_HEADERS_1.SOURCE, BINARY_HEADERS_1.ID];

const setterByHeader = {};
setterByHeader[Constants.BINARY_HEADERS_1.TYPE] = {
name: "type",
parser: (v) => v
};
setterByHeader[Constants.BINARY_HEADERS_1.SPEC_VERSION] = {
name: "specversion",
parser: () => "1.0"
};
setterByHeader[Constants.BINARY_HEADERS_1.SOURCE] = {
name: "source",
parser: (v) => v
};
setterByHeader[Constants.BINARY_HEADERS_1.ID] = {
name: "id",
parser: (v) => v
};
setterByHeader[Constants.BINARY_HEADERS_1.TIME] = {
name: "time",
parser: (v) => new Date(Date.parse(v))
};
setterByHeader[Constants.BINARY_HEADERS_1.DATA_SCHEMA] = {
name: "dataschema",
parser: (v) => v
};
setterByHeader[Constants.HEADER_CONTENT_TYPE] = {
name: "dataContentType",
parser: (v) => v
};
setterByHeader[Constants.BINARY_HEADERS_1.SUBJECT] = {
name: "subject",
parser: (v) => v
const setterByHeader = {
[BINARY_HEADERS_1.TYPE] : { name: "type", parser: (v) => v },
[BINARY_HEADERS_1.SPEC_VERSION] : { name: "specversion", parser: () => "1.0" },
[BINARY_HEADERS_1.SOURCE] : { name: "source", parser: (v) => v },
[BINARY_HEADERS_1.ID] : { name: "id", parser: (v) => v },
[BINARY_HEADERS_1.TIME] : { name: "time", parser: (v) => new Date(Date.parse(v)) },
[BINARY_HEADERS_1.DATA_SCHEMA] : { name: "dataschema", parser: (v) => v },
[HEADER_CONTENT_TYPE] : { name: "dataContentType", parser: (v) => v },
[BINARY_HEADERS_1.SUBJECT] : { name: "subject", parser: (v) => v }
};

// Leaving these in place for now. TODO: fixme
// eslint-disable-next-line
function checkDecorator(payload, headers) {
}
function checkDecorator(payload, headers) {}

// Leaving this in place for now. TODO: fixme
// eslint-disable-next-line
Expand All @@ -87,8 +57,8 @@ function Receiver(configuration) {
allowedContentTypes,
requiredHeaders,
Spec,
Constants.SPEC_V1,
Constants.BINARY_HEADERS_1.EXTENSIONS_PREFIX,
SPEC_V1,
BINARY_HEADERS_1.EXTENSIONS_PREFIX,
checkDecorator
);
}
Expand Down