Passing custom headers through to http.request()

[c-pius]

When using HttpEmitter.send() method, how can I pass additional header arguments (e.g. meant for our infrastructure) that are passed through to the http.request() call?

I tried to use

const emitter = new HTTPEmitter({
    url: "https://foo.bar"
})

const event = ...

emitter.send(event, {
  headers: {
    customheader: "...",
    authorization: "Bearer ...."
  }
})

When debugging, it seemed like the passed headers are overwritten by the default headers.

sdk-javascript/src/lib/bindings/http/emitter_binary.js

Line 56 in 99bb88b

const config = { ...options, ...defaults };

translated to

const config = Object.assign(Object.assign({}, options), defaults);

[lance]

@c-pius it looks like the spread operator assignment is a bug. Thanks for reporting this.

[lholmquist]

I wonder if there are other places that are like this?

[lholmquist]

To answer my own question. It looks like that is the only spot that the ordering was incorrect