-
Notifications
You must be signed in to change notification settings - Fork 29
Initial commit for ansible-test support #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for ansible-test support #63
Conversation
06ac834 to
11bb874
Compare
fbd85b9 to
1bc18b0
Compare
|
@wmudge should this still be draft or did you want a review? |
1bc18b0 to
919a531
Compare
5787fb4 to
edf772a
Compare
18f1782 to
3388e7b
Compare
3388e7b to
d64aaa7
Compare
|
Ready for review. You can run this by executing the following: # Sanity tests
ansible-test sanity --docker [--python 3.9]
# Unit tests (currently just the filter)
ansible-test units --docker [--python 3.9]
# And finally, the integration tests, which will spin up a Light and Medium (HA) duty environment using public/private networking
ansible-test integration --dockerMake sure you construct your own |
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
… Level 1 networking Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
67d0c2c to
6726a95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good.
Some comments/questions just to clarify before approval:
- Is it possible to run a test of idempotency with this or is that outside the scope of ansible-test?
- Some documentation for how to run these tests would be useful - e.g. in a TESTING.md or similar.
- Currently it is not possible to run these within cldr-runner the Container, only a venv. Is this expected or should there be another PR on cldr-runner to enable docker-in-docker support?
- See comment about example password in
integration_config.yml_templatefile.
Steps used to test:
- Checked-out feature branch of cloudera.exe for this PR.
- Created a virtual env with all requirments as per https://github.com/cloudera-labs/cldr-runner#local-development
- From the exe directory:
- Ran sanity check test suite with
ansible-test sanity --docker --python 3.9- worked successfully - Ran unit test for combine_onto filter with
ansible-test units --docker --python 3.9- worked successfully - Created a integration_config.yml file in tests/integration and ran integration tests with
ansible-test integration --docker- Light Duty worked successfully.
- Then encountered a timeout due to CDP API during Medium Duty test.
- Re-ran from this point with
--start-at medium_duty_l1.
- Ran sanity check test suite with
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wmudge -
Thanks for making the updated based on my initial review comments. I've re-tested this following your changes and all looks good. The idempotency test catches the current issue where the CDP CLI ignores default_sg which is great.
Approved.
Signed-off-by: Webster Mudge [email protected]