Skip to content

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented Nov 4, 2021

Signed-off-by: Webster Mudge [email protected]

@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Nov 4, 2021
@wmudge wmudge requested review from Chaffelson and cmperro November 4, 2021 16:12
@wmudge wmudge force-pushed the feature/ansible-test-support branch from 06ac834 to 11bb874 Compare November 9, 2021 16:56
@wmudge wmudge force-pushed the feature/ansible-test-support branch 3 times, most recently from fbd85b9 to 1bc18b0 Compare November 24, 2021 17:15
@Chaffelson
Copy link
Contributor

@wmudge should this still be draft or did you want a review?

@wmudge wmudge force-pushed the feature/ansible-test-support branch from 1bc18b0 to 919a531 Compare March 23, 2022 15:28
@wmudge wmudge force-pushed the feature/ansible-test-support branch 3 times, most recently from 5787fb4 to edf772a Compare April 5, 2022 18:59
@wmudge wmudge added this to the Version 1.7 milestone Apr 5, 2022
@wmudge wmudge force-pushed the feature/ansible-test-support branch 2 times, most recently from 18f1782 to 3388e7b Compare April 7, 2022 15:43
@wmudge wmudge force-pushed the feature/ansible-test-support branch from 3388e7b to d64aaa7 Compare April 28, 2022 18:57
@wmudge wmudge marked this pull request as ready for review April 28, 2022 19:00
@wmudge wmudge requested a review from jimright April 28, 2022 19:01
@wmudge
Copy link
Member Author

wmudge commented Apr 28, 2022

Ready for review.

You can run this by executing the following:

# Sanity tests
ansible-test sanity --docker [--python 3.9]

# Unit tests (currently just the filter)
ansible-test units --docker [--python 3.9]

# And finally, the integration tests, which will spin up a Light and Medium (HA) duty environment using public/private networking
ansible-test integration --docker

Make sure you construct your own integration_config.yml file from the template. This will contain secrets, so should not be included in any repo.

@wmudge wmudge force-pushed the feature/ansible-test-support branch from 67d0c2c to 6726a95 Compare May 9, 2022 18:23
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good.

Some comments/questions just to clarify before approval:

  • Is it possible to run a test of idempotency with this or is that outside the scope of ansible-test?
  • Some documentation for how to run these tests would be useful - e.g. in a TESTING.md or similar.
  • Currently it is not possible to run these within cldr-runner the Container, only a venv. Is this expected or should there be another PR on cldr-runner to enable docker-in-docker support?
  • See comment about example password in integration_config.yml_template file.

Steps used to test:

  • Checked-out feature branch of cloudera.exe for this PR.
  • Created a virtual env with all requirments as per https://github.com/cloudera-labs/cldr-runner#local-development
  • From the exe directory:
    • Ran sanity check test suite with ansible-test sanity --docker --python 3.9 - worked successfully
    • Ran unit test for combine_onto filter with ansible-test units --docker --python 3.9 - worked successfully
    • Created a integration_config.yml file in tests/integration and ran integration tests with ansible-test integration --docker
      • Light Duty worked successfully.
      • Then encountered a timeout due to CDP API during Medium Duty test.
      • Re-ran from this point with --start-at medium_duty_l1.

wmudge added 3 commits June 17, 2022 16:34
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
@jimright jimright self-requested a review July 5, 2022 21:14
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wmudge -

Thanks for making the updated based on my initial review comments. I've re-tested this following your changes and all looks good. The idempotency test catches the current issue where the CDP CLI ignores default_sg which is great.

Approved.

@wmudge wmudge merged commit da0139a into cloudera-labs:devel Jul 14, 2022
@wmudge wmudge deleted the feature/ansible-test-support branch September 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG

Development

Successfully merging this pull request may close these issues.

3 participants