Skip to content

Fix Azure deployment #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fix Azure deployment #128

merged 2 commits into from
Nov 15, 2022

Conversation

@jimright
Copy link
Contributor

This PR fixes two minor issues to fix (re-)deployment of CDP Public Cloud on Azure.

  • Added role assignment for the Azure Ranger Audit role following a CDP change of the required permissions on the MSI. This fixes Azure Authz missing a role assignation to the Audit Role -> Failed Provisioning #126.
  • During teardown change deletion of the AD app from just deletion of the Service Principal to deletion of the full Application. It seems an update of the az cli means that delete of the SP doesn't delete the App.

Tested these changes by deploying an Azure-based environment, then ran a full teardown and then redeployed. All worked successfully.

@jimright jimright requested a review from cmperro September 16, 2022 14:01
@jimright jimright requested a review from a team October 13, 2022 19:44
cmperro
cmperro approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@cmperro cmperro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Testing a run and teardown. Env/DL registers successfully and the cross account app is actually deleted.

@wmudge wmudge self-requested a review November 9, 2022 15:34
@wmudge wmudge added the bug POINT - Bugfix entry in the CHANGELOG label Nov 9, 2022
@wmudge wmudge changed the base branch from devel to main November 15, 2022 18:24
@wmudge wmudge changed the base branch from main to devel November 15, 2022 18:26
@wmudge wmudge merged commit 1a1b3fd into cloudera-labs:devel Nov 15, 2022
wmudge added a commit to wmudge/cloudera.exe that referenced this pull request Aug 12, 2025
@wmudge
Update collection version to 2.1.0 (cloudera-labs#128)
8c77f75 
Signed-off-by: Webster Mudge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge approved these changes

+1 more reviewer

@cmperro cmperro cmperro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug POINT - Bugfix entry in the CHANGELOG

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jimright @cmperro @wmudge