Skip to content

Fix MSI teardown to delete MSIs #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Fix MSI teardown to delete MSIs #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/platform/tasks/initialize_teardown_azure.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@
- "{{ plat__azure_datalakeadmin_identity_name }}"
- "{{ plat__azure_log_identity_name }}"
- "{{ plat__azure_ranger_audit_identity_name }}"
role_assignment_assignee_list: "{{ msi_principal_id_list | union([plat__azure_application_service_principal_objuuid]) | list }}"
role_assignment_assignee_list: "{{ msi_principal_id_list | union([plat__azure_application_service_principal_objuuid | default([])]) | list }}"

10 changes: 4 additions & 6 deletions roles/platform/tasks/teardown_azure_authz.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@
api_version: '2018-11-30'
idempotency: yes
state: absent
body:
location: "{{ plat__region }}"
loop:
- "{{ plat__azure_idbroker_identity_name }}"
- "{{ plat__azure_datalakeadmin_identity_name }}"
Expand All @@ -60,10 +58,10 @@
delay: 5
retries: 10
until:
- plat__azure_idbroker_identity_name in discovered_msi_list
- plat__azure_datalakeadmin_identity_name in discovered_msi_list
- plat__azure_log_identity_name in discovered_msi_list
- plat__azure_ranger_audit_identity_name in discovered_msi_list
- plat__azure_idbroker_identity_name not in discovered_msi_list
- plat__azure_datalakeadmin_identity_name not in discovered_msi_list
- plat__azure_log_identity_name not in discovered_msi_list
- plat__azure_ranger_audit_identity_name not in discovered_msi_list
vars:
discovered_msi_list: "{{ __azure_identity_list.response | map(attribute='name') | list }}"

Expand Down