Skip to content

Add control_plane and control_plane_info modules #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 28, 2025
Merged

Add control_plane and control_plane_info modules #312

merged 16 commits into from
Jul 28, 2025

Conversation

jimright
Copy link
Contributor

@jimright jimright commented Jul 2, 2025

No description provided.

@jimright jimright added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Jul 2, 2025
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jul 2, 2025
@jimright jimright force-pushed the feature/control_plane_module branch from 5b9968a to f8eb6e1 Compare July 4, 2025 19:48
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jul 4, 2025
@jimright jimright force-pushed the feature/control_plane_module branch from 6bb9813 to b11d71d Compare July 8, 2025 20:34
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Jul 8, 2025
jimright added 9 commits July 8, 2025 21:38
@jimright
Add control_plane and control_plane_info modules
14bf44f 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix lint issues and add control_plane_info test
1be11ef 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix lint error on control_plane_info tests
8a211da 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix tflint on control plane tests
91ea017 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix various tflint issues
f8be18f 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix tflint after rebase
b5c0054 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix tflint issues
e8bc005 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Add action group for control plane
5aab031 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix tflint issues
54aa079 
Signed-off-by: Jim Enright <[email protected]>
@jimright jimright force-pushed the feature/control_plane_module branch from b11d71d to 54aa079 Compare July 8, 2025 20:39
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jul 8, 2025
wmudge
wmudge requested changes Jul 8, 2025
View reviewed changes
jimright added 3 commits July 9, 2025 13:02
@jimright
Updates based on PR feedback
1bf2bdf 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Fix lint issues
a6d0984 
Signed-off-by: Jim Enright <[email protected]>
@jimright
Update formatting in module doc notes
acba31b 
Signed-off-by: Jim Enright <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jul 9, 2025
@wmudge wmudge self-requested a review July 10, 2025 16:51
@jimright
Add diff mode support
868da65 
Signed-off-by: Jim Enright <[email protected]>
wmudge
wmudge requested changes Jul 10, 2025
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and types still outstanding

@jimright
Fix lint issues
fdea3a5 
Signed-off-by: Jim Enright <[email protected]>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Jul 11, 2025
@jimright jimright marked this pull request as ready for review July 15, 2025 14:38
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Jul 15, 2025
@wmudge wmudge merged commit 1037b60 into cloudera-labs:devel Jul 28, 2025
8 checks passed
@wmudge wmudge added this to the Release 5.0.0 milestone Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG

Milestone

Release 5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jimright @wmudge