Skip to content

Update host_template module and tests #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 28, 2025
Merged

Update host_template module and tests #281

merged 8 commits into from
Apr 28, 2025

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Apr 17, 2025

No description provided.

wmudge added 4 commits April 17, 2025 14:57
@wmudge
Update parse_host_template and rename
1704cc5 
Add create_host_template_model utility

Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Refactor host_template to handle base role config groups by service a…
39d55e5 
…nd type only

Add purge parameter for managing role config group membership

Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Update host_template tests to use pytest fixture factories and expand…
bf4e2e2 
… test coverage

Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Fix copyright and imports
1cb0e52 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge wmudge added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Apr 17, 2025
@wmudge wmudge added this to the Release 4.5.0 milestone Apr 17, 2025
@wmudge wmudge requested a review from a team April 17, 2025 19:00
@wmudge wmudge changed the title Update host_template module Update host_template module and tests Apr 17, 2025
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Apr 17, 2025
@wmudge wmudge marked this pull request as draft April 17, 2025 19:19
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Apr 17, 2025
wmudge added 3 commits April 17, 2025 15:42
@wmudge
Add host_template_factory() pytest fixture
6775c6f 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Add de/register_host_template() test utilities
f95d747 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Update host_template_info module to use utility functions
c2f61ce 
Rework host_template_info module tests to use pytest fixtures

Signed-off-by: Webster Mudge <[email protected]>
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Apr 18, 2025
@wmudge wmudge marked this pull request as ready for review April 18, 2025 13:28
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Apr 18, 2025
jimright
jimright approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit f223707 into cloudera-labs:devel Apr 28, 2025
8 checks passed
@wmudge wmudge deleted the feature/host_template-refactoring branch April 28, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimright jimright jimright approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG validated The pull request has passed the prechecks

Milestone

Release 5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wmudge @jimright