-
Notifications
You must be signed in to change notification settings - Fork 50
Update service and service_info modules to align with current utilities #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wmudge
merged 27 commits into
cloudera-labs:devel
from
wmudge:feature/service-refactoring
Apr 17, 2025
Merged
Update service and service_info modules to align with current utilities #280
wmudge
merged 27 commits into
cloudera-labs:devel
from
wmudge:feature/service-refactoring
Apr 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
…nfig groups Update the get_base_role_config_group to retrieve base groups for all types Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
…config groups for a service Signed-off-by: Webster Mudge <[email protected]>
…ields. Update service module to provision and reconcile role config groups. Update service module to handle maintenance mode. Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Break out role config group management into separate test script. Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Removed host_ids from roles parameter. Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
…ation Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Update argspec for role_config_group parameter Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Signed-off-by: Webster Mudge <[email protected]>
Update service_info tests to use pytest fixtures Signed-off-by: Webster Mudge <[email protected]>
rsuplina
approved these changes
Apr 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
MINOR - New feature or enhancement entry in the CHANGELOG
validated
The pull request has passed the prechecks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.