Skip to content

Update service_role_config_group_info module to align with existing modules #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 7, 2025
Merged

Update service_role_config_group_info module to align with existing modules #270

merged 9 commits into from
Mar 7, 2025

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Mar 5, 2025

No description provided.

@wmudge wmudge added the enhancement MINOR - New feature or enhancement entry in the CHANGELOG label Mar 5, 2025
@wmudge wmudge added this to the Release 4.5.0 milestone Mar 5, 2025
@wmudge wmudge requested a review from a team March 5, 2025 22:08
@wmudge wmudge force-pushed the update/service_role_config_group_info-alignment branch from 4eb1501 to ddb1483 Compare March 5, 2025 22:12
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Mar 5, 2025
rsuplina
rsuplina approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@rsuplina rsuplina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@github-actions github-actions bot added the validated The pull request has passed the prechecks label Mar 7, 2025
wmudge added 9 commits March 7, 2025 11:18
@wmudge
Update service_role_config_group_info and test to align with cm_servi…
a852b5f 
…ce_role_config_group_info

Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Update Hatch env to remove pytest-ansible and tox-ansible
02d883c 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Fix erroneous variable
2e74145 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Add cms_session fixture and update zk_auto fixture to use cluster hosts
4295fe3 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Update tests for type, name, and all
7d8b150 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Add check for parcel and limit ZK hosts to cluster
e560759 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Update if/else statement logic
9fa775d 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Add lookup for base role config group name for testing
9e5bb2b 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge
Remove extra line
d98ce45 
Signed-off-by: Webster Mudge <[email protected]>
@wmudge wmudge force-pushed the update/service_role_config_group_info-alignment branch from 0e8dcf1 to d98ce45 Compare March 7, 2025 16:20
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Mar 7, 2025
@wmudge wmudge merged commit 2a8a701 into cloudera-labs:devel Mar 7, 2025
7 checks passed
@wmudge wmudge deleted the update/service_role_config_group_info-alignment branch March 7, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsuplina rsuplina rsuplina approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement entry in the CHANGELOG validated The pull request has passed the prechecks

Milestone

Release 5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wmudge @rsuplina