Add Host Template Module #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rsuplina <[email protected]>
rsuplina
added
the
enhancement
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
wmudge
requested changes
Jun 26, 2024
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
removed
the
validated
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
wmudge
requested changes
Jul 29, 2024
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
wmudge
requested changes
Jul 29, 2024
plugins/modules/host_template.py
Outdated
| cluster=dict(required=True, type="str", aliases=["cluster_name"]), | ||
| name=dict(required=True, type="str"), | ||
| role_groups=dict( | ||
| required=True, type="list", aliases=["role_config_groups"] |
There was a problem hiding this comment.
Still is showing required. This needs to moved to a required_if that is pinned to state=present condition.
Signed-off-by: rsuplina <[email protected]>
github-actions
bot
added
validated
wmudge
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit contains: