Skip to content

fix: Handle JSON responses #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

fix: Handle JSON responses #341

merged 2 commits into from
Mar 17, 2025

Conversation

janepie
Copy link
Contributor

@janepie janepie commented Mar 17, 2025

Sends the response text immediately if the response type is set to json
Made for dealing with a JSONResponse that does not include an OCS object

@janepie janepie requested a review from bigcat88 March 17, 2025 15:29
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (c8c6374) to head (55d2e09).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nc_py_api/_session.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #341      +/-   ##
==========================================
- Coverage   94.55%   94.52%   -0.04%     
==========================================
  Files          46       46              
  Lines        5385     5389       +4     
==========================================
+ Hits         5092     5094       +2     
- Misses        293      295       +2     
Files with missing lines Coverage Δ
nc_py_api/nextcloud.py 96.34% <100.00%> (ø)
nc_py_api/_session.py 94.20% <50.00%> (-0.52%) ⬇️
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jana Peper <[email protected]>
@janepie janepie force-pushed the fix/json-response branch from afdaa7e to c66b2b9 Compare March 17, 2025 15:42
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thank you!

@bigcat88 bigcat88 merged commit bd674b9 into main Mar 17, 2025
13 checks passed
@bigcat88 bigcat88 deleted the fix/json-response branch March 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants