Skip to content

Use system trust store by default #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Use system trust store by default #328

merged 2 commits into from
Jan 19, 2025

Conversation

bigcat88
Copy link
Member

After internal discussion with @kyteinsky when we tested this nextcloud/app_api#448 - it was found out that the test-deploy ExApp from AppAPI "Test Deploy" button action fails in such setups, since the Python library "httpx" ignores system certificates by default.

reference: encode/httpx#302

Temporary workaround, until "httpx" will change it's behavior.

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (78a6f76) to head (a4d859d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   94.68%   94.68%           
=======================================
  Files          46       46           
  Lines        5365     5367    +2     
=======================================
+ Hits         5080     5082    +2     
  Misses        285      285           
Files with missing lines Coverage Δ
nc_py_api/_version.py 100.00% <100.00%> (ø)
nc_py_api/options.py 100.00% <100.00%> (ø)

@bigcat88 bigcat88 merged commit 301296d into main Jan 19, 2025
20 checks passed
@bigcat88 bigcat88 deleted the fix/system-certs branch January 19, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant