Skip to content

user creation: fixed incorrect "displayname" param #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,19 @@

All notable changes to this project will be documented in this file.

## [0.12.1 - 2024-04-05]

### Fixed

- Incorrect `Display name` when creating user, which led to the parameter being ignored. #239 Thanks to @derekbuckley

## [0.12.0 - 2024-04-02]

Update with new features only for `NextcloudApp` class. #233

### Added

- `ex_app.get_computation_device` function for retrieving GPU type(only with AppAPI `2.4.0`+).
- `ex_app.get_computation_device` function for retrieving GPU type(only with AppAPI `2.5.0`+).
- `ex_app.integration_fastapi.fetch_models_task` are now public function, added `progress_init_start_value` param.
- Global authentication when used now sets `request.scope["username"]` for easy use.

Expand Down
2 changes: 1 addition & 1 deletion nc_py_api/users.py
Original file line number Diff line number Diff line change
Expand Up @@ -378,5 +378,5 @@ def _create(user_id: str, display_name: str | None, **kwargs) -> dict[str, typin
if k in kwargs:
data[k] = kwargs[k]
if display_name is not None:
data["displayname"] = display_name
data["displayName"] = display_name
return data