Skip to content

CLJS-3322: Upgrade to latest Closure Library - handle non-legacy GCL goog.module namespaces #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Oct 15, 2021
Merged

CLJS-3322: Upgrade to latest Closure Library - handle non-legacy GCL goog.module namespaces #105

merged 13 commits into from
Oct 15, 2021

Conversation

swannodette
Copy link
Member

@swannodette swannodette commented Oct 11, 2021 •
edited
Loading

(WIP) two things are still failing:

  • goog.module files not parsed properly for var checking support
  • int predicates in self-parity tests

@swannodette
(wip)
2ff3b08 
* bump glib
* :require module loader instead of :import - not a legacy namespace anymore
* add goog.module handling case to analyzer
* add goog.module handling case to compiler
* add tests
@swannodette
(wip)
4d14d42 
* add missing case to browser REPL bootstrap for goog.module
@swannodette
(wip)
703e101 
* revert cljs.loader change for now
* generalize munge-goog-module-lib
* add resolve-import helper
* fixup emission test
@swannodette
(wip)
b50e5d2 
* resolve goog.module imports in resolve-var
* test cases
* check that emission doesn't shadow import usage
@swannodette swannodette force-pushed the cljs-3322-update-glib branch from e6f3586 to b50e5d2 Compare October 11, 2021 22:15
@swannodette
(wip)
c8710ed 
* bump gcl
@swannodette
(wip)
fa5e135 
* wrap goog.module.get in goog.scope to avoid silly Closure warnings
@swannodette
(wip)
8303f2e 
* remove dependency on goog.object from cljs.core macros file
@swannodette swannodette changed the title CLJS-3322: Upgrade to Closure Library 0.0-20210811-6da97fe1 - handle non-legacy goog.module CLJS-3322: Upgrade to latest Closure Library - handle non-legacy goog.module Oct 12, 2021
@swannodette swannodette changed the title CLJS-3322: Upgrade to latest Closure Library - handle non-legacy goog.module CLJS-3322: Upgrade to latest Closure Library - handle non-legacy GCL goog.module namespaces Oct 12, 2021
@swannodette
(wip)
23b9a84 
* add comment about goog.scope workaround
@swannodette
(wip)
b98f33b 
* add docstrings to extern parsing ns
* cleanup formatting
* cleanup requires
* add Token/FUNCTION case
* Token/NAME should check for simple name
* handle goog.module case in parse-externs
* make parsed->defs a multimethod
@swannodette
(wip)
1438ba3 
* add resource->source-file helper
@swannodette
(wip)
16eb3ac 
* ^Node type hints
* in NAME case stop if parent is OBJECTLIT
* STRING_KEY case does not need split on .
* when parsing goog.modules, only provide ClojureScript defs for exported defs
@swannodette
(wip)
c97d630 
* remove unneeded condition
@swannodette
(wip)
50af5dc 
* add internal reference to goog.math.Long
* update tests, leave explanatory comment
@swannodette swannodette merged commit 76ac6bf into master Oct 15, 2021
@swannodette swannodette deleted the cljs-3322-update-glib branch December 16, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@swannodette