CLJS-3324: hash-map behavior differs from Clojure #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add runtime check to hash-map w/o changing perf. Add runtime check to PersistentHashMap.fromArrays w/o significant perf change. hash-map is also an inlining macro which invokes PersistentHashMap.fromArrays. naive use of partition leads to garbage in / out. Pad to fill in the missing value, then remove - then when computing the values drop when we hit a non-pair. This way we get non-matching array lengths and can defer to the runtime check. Add tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add runtime check to hash-map w/o changing perf.
Add runtime check to PersistentHashMap.fromArrays w/o significant perf change.
hash-map is also an inlining macro which invokes PersistentHashMap.fromArrays.
naive use of partition leads to garbage in / out. Pad to fill in the missing value,
then remove - then when computing the values drop when we hit a non-pair. This way
we get non-matching array lengths and can defer to the runtime check.
Add tests.