Close output channel on error #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdallo
reviewed
Oct 24, 2023
| (write-message writer msg) | ||
| (catch Throwable e | ||
| (async/close! messages) | ||
| (throw e))) |
Member
There was a problem hiding this comment.
I suppose this throw is enough to the developer know this was a JSON parse exception or something right?
Contributor
Author
There was a problem hiding this comment.
I think it depends a bit on the setup. Because this runs within a core.async/thread, the exception is probably given to the thread's uncaught exception handler. I think the default one will dump the stack trace to stderr, but many logging frameworks will allow to install a custom handler to log those. Definitely something people should do.
As a library, I figured we should stay un-opinionated here and just throw.
mainej
approved these changes
Oct 24, 2023
Contributor
mainej
left a comment
mainej
left a comment
There was a problem hiding this comment.
Seems like a practical solution. One suggestion below, but looks good!
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41
This approach closes the output channel when writing a message to the output stream fails for any reason. Expected reasons are:
This will prevent the server from blocking forever on a channel that has no more consumers. Instead, messages will be dropped.
We expect that the client will send an exit message and eventually close the connection. This will close the server's input channel and allow it to terminate.