build-artifact? throws NPEs when not using leiningen or boot

[kotarak]

Not using one of the named systems causes NPEs being thrown in the repl, for example when typing a namespaced keyword. Obviously build-artifact? fails to check for nil in line 60 of core.clj.

project-root fails to identify the project root correctly because it does only look for project.clj or build.boot. From the top of my head I could imagine other sensible values like .project, build.gradle, pom.xml, .git, .hg or _darcs.

On the one hand this list is not exhaustive. On the other hand none of them might indicate the true root of the system. So some possibility to hook into that logic would be nice.

(At the moment I monkey patch project-root to (contantly (System/getProperty "user.dir")), but that feels rather dirty.)

[benedekfazekas]

any chance you can put together a PR for this?

[kotarak]

Well, it depends on your strategy for this.

Adding at least build.gradle and pom.xml is faster done directly than creating a PR. Anything more involved requires some discussion on the "if" and (if yes) the "how", I guess.

I personally can also live with the monkey patch, if the decision is that the majority of the users don't have this problem.

[expez]

Why would you ever want to write clojure without using either lein or boot?

[kotarak]

Because company policy doesn't allow?

[bbatsov]

Probably CIDER itself needs to add some basic support for Maven and Gradle - e.g. cider-jack-in should work with them out of the box.

[benedekfazekas]

you are right about gradle and pom. I would only prefer PR exactly because this needs some discussion. Always easier to reason about a problem if there is code around it. Appreciate if you think this is a waste of time

[kotarak]

@bbatsov you can ping me for the basic requirements regarding gradle for that.

[expez]

Supporting both boot and leiningen is as far as I'm willing to go. I don't want to have to think about maven, ant, gradle and whatever other build systems people might be using. Even now, boot support is spotty because the API is slightly different.

I'm fine with fixing this issue, but that's likely just going to be the beginning of your problems. Your situation is somewhat unique, so it doesn't make much sense spending time, or inflating the code base, to support it.

[kotarak]

Fair decision.