Skip to content

[inspect] Hexdump view mode #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2025
Merged

[inspect] Hexdump view mode #342

merged 3 commits into from
May 28, 2025

Conversation

alexander-yakushev
Copy link
Member

@alexander-yakushev alexander-yakushev commented May 26, 2025 •
edited
Loading

Here is how it looks:

image
  • Inspired by hexdump tool.
  • Supports paging (renders 16*page-size of bytes).
  • Currently only works for byte arrays. I may add support for ByteBuffers in the future, based on the feedback.
  • You've added tests to cover your change(s)
  • You've updated the changelog (if adding/changing user-visible functionality)

Copilot

This comment was marked as resolved.

Sign in to view

@clojure-emacs clojure-emacs deleted a comment from Copilot AI May 26, 2025
@clojure-emacs clojure-emacs deleted a comment from Copilot AI May 26, 2025
@clojure-emacs clojure-emacs deleted a comment from Copilot AI May 26, 2025
bbatsov
bbatsov reviewed May 28, 2025
View reviewed changes
src/orchard/inspect.clj Outdated
(let [c (bit-and b 0xFF)]
(if (and (>= c 32) (<= c 126))
(char c)
;; Use MIDOT ABOVE for non-printed chars as it is distinct from 0x2E.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MIDOT ABOVE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was DOT ABOVE first, and then I changed it to MIDDLE DOT, and the comment went halfway through 😆

bbatsov
bbatsov approved these changes May 28, 2025
View reviewed changes
Copy link
Member

@bbatsov bbatsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (and useful) to me!

@alexander-yakushev alexander-yakushev merged commit 868047d into master May 28, 2025
18 checks passed
@alexander-yakushev alexander-yakushev deleted the hexdump branch May 28, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@bbatsov bbatsov bbatsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexander-yakushev @bbatsov