Inspector analytics improvements #339
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part is pretty minor – allow analytics for all maps and for arrays.
The second part is a bit more involved. Sometimes, it is beneficial to display a map as map after you order it somehow – sort by keys or values or anyhow else. However, turning that sorted list of MapEntries back into an array-map just so that inspector or printer displays it properly without messing up the entry order is inefficient. Thus, I've added a meta flag that is interpreted by inspector, printer, and pretty-printer as "show this sequence of mapentries as a map".This is currently only used for displaying frequencies computed by inspector analytics. We have tests for that functionality, so no new tests are necessary.