Skip to content

Conversation

niquola
Copy link

@niquola niquola commented Jan 17, 2022

io/resource may return nil in some situations (in my case it was emacs recovery file)

io/resource may return nil in some situations
@vemv
Copy link
Member

vemv commented Jan 17, 2022

Hi! Thanks for the contribution. Could you describe the problem being solved?

Thanks - V

@bbatsov
Copy link
Member

bbatsov commented Jan 17, 2022

Some background. I'm also not sure when exactly this problem manifests. We'll need some unit tests covering this scenario as well.

@vemv
Copy link
Member

vemv commented Jan 17, 2022

In any case, maybe the fix could be moved to misc/clj-file?

I'll have a calmer look at the screenshots

@vemv vemv closed this in 2728d6f Jan 17, 2022
@vemv
Copy link
Member

vemv commented Jan 17, 2022

I pushed the fix directly to master out of muscle memory, sorry.

It's essentially the same, with some bonus performance considerations.

If you can pass us an exact emacs recovery file (just the filename, absolute), we'd be happy to add it to the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants