Skip to content

Conversation

vspinu
Copy link
Contributor

@vspinu vspinu commented Jun 3, 2014

Fix the issues with stacktraces in #602. I have renamed the cider-popup-on-error because it wasn't really doing any popup and the name was conflicting with cider-popup-stacktraces.

@bbatsov
Copy link
Member

bbatsov commented Jun 3, 2014

Have a look at my final remarks regarding #602. I think we should combine all stacktrace variables into one. The current situation is more complex and more confusing than it needs to be.

@vspinu
Copy link
Contributor Author

vspinu commented Jun 4, 2014

I have just implemented the proposed popup behavior.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: s/poped/popped/

@jeffvalk
Copy link
Contributor

jeffvalk commented Jun 4, 2014

@Vitoshka Nice!

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should rename this to cider-show-stacktrace-buffer. (or something like that) I find the entire popup terminology a bit confusing.

@bbatsov
Copy link
Member

bbatsov commented Jun 4, 2014

Address my remarks and squash all commits into one. Your commit message should be with the format [Fix #602] Change .... See CONTRIBUTING.md for details. You should also add a changelog entry.

README.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps those should be sub-bullets.

@bbatsov bbatsov added this to the v0.7 milestone Jun 6, 2014
@bbatsov
Copy link
Member

bbatsov commented Jun 9, 2014

@Vitoshka Ping :-)

@vspinu
Copy link
Contributor Author

vspinu commented Jun 9, 2014

Sorry, I have had a very busy week. Will address all of your comments in the following days.

@vspinu
Copy link
Contributor Author

vspinu commented Jun 11, 2014

Hi. I have just commited a new patch.Should be fine this time.

bbatsov added a commit that referenced this pull request Jun 11, 2014
produce stacktrace buffer even when cider-popup-stacktraces is nil
@bbatsov bbatsov merged commit e6bfe3b into clojure-emacs:master Jun 11, 2014
@vspinu vspinu deleted the on-error branch June 11, 2014 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants