Skip to content

Conversation

pdbrown
Copy link
Contributor

@pdbrown pdbrown commented Oct 17, 2022

This is a little fix to make the repl buffer scroll to the bottom after cider-insert-in-repl when it's in another frame. It doesn't currently scroll in other frames because get-buffer-window only considers the current one by default. Setting the opt arg t means to consider all windows on all existing frames (and seems to start with the selected frame).

@bbatsov
Copy link
Member

bbatsov commented Oct 26, 2022

Can you please mention this in the changelog?

after using cider-insert-in-repl.
@pdbrown pdbrown force-pushed the fix/scroll-repl-other-frame branch from 032819b to 59eeafe Compare November 9, 2022 20:55
@pdbrown
Copy link
Contributor Author

pdbrown commented Nov 9, 2022

Yep! Added a note to the changelog.

@bbatsov bbatsov merged commit 5064287 into clojure-emacs:master Nov 9, 2022
@bbatsov
Copy link
Member

bbatsov commented Nov 9, 2022

Thanks!

@pdbrown pdbrown deleted the fix/scroll-repl-other-frame branch July 26, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants