Skip to content

Conversation

plexus
Copy link
Contributor

@plexus plexus commented Oct 11, 2021

If the " *nrepl-decoding*" buffer already exists then it is likely already in
the right mode. Not re-initializing the mode means we don't re-trigger hooks,
which in this case in particular prevents an unfortunate interaction with
evil-mode, where the cursor color gets updated even though it shouldn't.

Fixes #3068

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@plexus plexus force-pushed the fix-3068-evil-cursor-color branch from 102c380 to 69606fa Compare October 11, 2021 08:05
@vemv
Copy link
Member

vemv commented Oct 11, 2021

There's another call at

(fundamental-mode)
- maybe we can extract a helper and apply it in both places?

If the `" *nrepl-decoding*"` buffer already exists then it is likely already in
the right mode. Not re-initializing the mode means we don't re-trigger hooks,
which in this case in particular prevents an unfortunate interaction with
evil-mode, where the cursor color gets updated even though it shouldn't.

Fixes clojure-emacs#3068
@plexus plexus force-pushed the fix-3068-evil-cursor-color branch from 69606fa to 316564e Compare October 11, 2021 09:06
@plexus
Copy link
Contributor Author

plexus commented Oct 11, 2021

  • maybe we can extract a helper and apply it in both places?

Done!

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☕️☕️

@plexus
Copy link
Contributor Author

plexus commented Oct 11, 2021

Sorry @vemv only 🍵 for me 🙏

@bbatsov bbatsov merged commit f6dda2d into clojure-emacs:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CIDER doesn't play well with evil-set-cursor-color

3 participants