New feature: Enlighten #1545
Merged
New feature: Enlighten #1545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've just signed LT's death sentence. :-) The code looks good - all we need now is some documentation and a changelog entry. You can add this (or an animated gif) in the README. |
|
Simply awesome! 👍 |
|
Sweet! |
|
Thanks. :-)
Yeah, I'll start writing that now. |
Malabarba
force-pushed
the
enlighten
branch
2 times, most recently
from
287f8f5 to
5d5653c
Compare
|
The docs look good. Guess you can squash the commits and we can merge this. |
README.md
Outdated
| (setq cider-stacktrace-fill-column 80) | ||
| ``` | ||
|
|
||
| ### Enlighten (Light Table) |
There was a problem hiding this comment.
Btw, maybe the reference to "Light Table" will be big misleading, as most people will think this is something like "InstaREPL".
Handle :enlighten messages through the debug channel. Define cider-enlighten-mode. Font-lock enlightened defns. Document Enlighten.
Malabarba
force-pushed
the
enlighten
branch
2 times, most recently
from
24ba6f6 to
c4e55e2
Compare
|
This is awesome! |
|
😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Enlighten feature in clojure-emacs/cider-nrepl#296.
Take a file like the following:
Turning on
cider-enlighten-modeand evaluating the sexps one by one (C-c C-kdoesn't work) will lead to this: